First Pass - Githubissues

mcollina / hyperemitter

Horizontally Scalable EventEmitter powered by a Merkle DAG

ISC License

70 stars 2 forks source link

First Pass #1

Closed mcdonnelldean closed 9 years ago

mcdonnelldean commented 9 years ago

Just some tidy of tests and examples,

I've more to add but I'd like to get the structure synced so I don't hit rebase hell later. Don't pull this yet as there is still docs to finish before I am happy.

added npm debug logs to .gitignore
moved tests and fixtures into /test, update package.json accordingly
moved example.js into /eg
added emit before on example
added idempotency example
added example schema for example files
added basic-example.js
tidied over some naming and comments
Updated Docs

mcollina commented 9 years ago

Thanks for the help, it is really welcomed! I hope the various comments clarifies things a bit.

mcdonnelldean commented 9 years ago

@mcollina No hassle :D I think examples help. Don't pull it until the examples a technically correct though. I want them to be right.

mcdonnelldean commented 9 years ago

@mcollina Ok, this is me finished on this PR, let me know what needs changing.

mcollina commented 9 years ago

I'm not in for having a separate folder for the docs, can you please get them back into the main README file? This module should be simple enough to a have a single page README, and I have some thoughts that this module is already doing too much :D. I also prefer the examples folder be named examples. I would rename the docs/contributing.md file into CONTRIBUTING.md.

mcdonnelldean commented 9 years ago

Cool. Let me change in around in an hour or so and re push

mcdonnelldean commented 9 years ago

@mcollina Take a gander over that.

mcdonnelldean commented 9 years ago

@mcollina IO.js is giving the issue below But I'm not getting the issue with IO.js 2.0.0

mcollina commented 9 years ago

leveldown requires a bump, it's coming tomorrow or earlier Il giorno mar 5 mag 2015 alle 12:09 Dean McDonnell notifications@github.com ha scritto:

@mcollina https://github.com/mcollina ^^ IO.js is giving the issue But I'm not getting the issue with IO.js 2.0.0

— Reply to this email directly or view it on GitHub https://github.com/mcollina/hyperemitter/pull/1#issuecomment-99018623.

mcdonnelldean commented 9 years ago

@mcollina Cool, interersting, I presume it worked locally because I already have level built? Not to worry, I have added back the example too.