Add support for Memdb v1.x

[asbjornenge]

I was using hyperemitter for a new project with memdb@1.0.0 installed. I can't figure out exactly what happens but it messes up connections somehow. Tried upgrading on my fork and the tests just hang. Downgrading to 0.2.0 makes everything run smoothly. FYI :stuck_out_tongue_closed_eyes: :wave:

[mcollina]

The levelup version we depend on is not officially compatible with leveldown memdown v1.x. So, that's part of the problem. If you want to submit a PR on that, I would be super-happy to have it in!

[mcdonnelldean]

Hi @asbjornenge I added some tags and modified the title. This would be awesome to have so I wanted to make sure we can see at a glance what it is. Like Matteo I would also be super happy to see this PR'd if you want to take a stab at it.

[mcollina]

The problem is that we depend on levelup 0.x which uses leveldown 0.x. The interface changed slightly between leveldown 0.x to 1.x, and so the failings. Once levelup goes 1.0, we can update @mafintosh hyperlog and then this one too.

Also, we might want to make the tests more modular, so we can test things both on memdown and leveldown.

[asbjornenge]

Sorry for the late reply on this. I've been conferencing and travelling and stuff :stuck_out_tongue_closed_eyes: I have a few other things to finish up before I can look at this. But it sounds like @mcollina is on top if it? Levelup is @ 1.1.0 btw.

[mcollina]

Ouch, then we should start updating things! :D cc @mafintosh Il giorno dom 24 mag 2015 alle 21:12 Asbjorn Enge notifications@github.com ha scritto:

Sorry for the late reply on this. I've been conferencing and travelling and stuff [image: :stuck_out_tongue_closed_eyes:] I have a few other things to finish up before I can look at this. But it sounds like @mcollina https://github.com/mcollina is on top if it? Levelup is @ 1.1.0 btw.

— Reply to this email directly or view it on GitHub https://github.com/mcollina/hyperemitter/issues/12#issuecomment-105050555 .

[mcdonnelldean]

What impact does this have on the work I'm doing. I presume none?

Kindest Regards,

Dean

On 24 May 2015, at 20:13, Matteo Collina notifications@github.com wrote:

Ouch, then we should start updating things! :D cc @mafintosh Il giorno dom 24 mag 2015 alle 21:12 Asbjorn Enge notifications@github.com ha scritto:

Sorry for the late reply on this. I've been conferencing and travelling and stuff [image: :stuck_out_tongue_closed_eyes:] I have a few other things to finish up before I can look at this. But it sounds like @mcollina https://github.com/mcollina is on top if it? Levelup is @ 1.1.0 btw.

— Reply to this email directly or view it on GitHub https://github.com/mcollina/hyperemitter/issues/12#issuecomment-105050555 .

— Reply to this email directly or view it on GitHub.

[mcollina]

None. Il giorno dom 24 mag 2015 alle 21:14 Dean McDonnell < notifications@github.com> ha scritto:

What impact does this have on the work I'm doing. I presume none?

Kindest Regards,

Dean

On 24 May 2015, at 20:13, Matteo Collina notifications@github.com wrote:

Ouch, then we should start updating things! :D cc @mafintosh Il giorno dom 24 mag 2015 alle 21:12 Asbjorn Enge < notifications@github.com> ha scritto:

Sorry for the late reply on this. I've been conferencing and travelling and stuff [image: :stuck_out_tongue_closed_eyes:] I have a few other things to finish up before I can look at this. But it sounds like @mcollina https://github.com/mcollina is on top if it? Levelup is @ 1.1.0 btw.

— Reply to this email directly or view it on GitHub < https://github.com/mcollina/hyperemitter/issues/12#issuecomment-105050555>

.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/mcollina/hyperemitter/issues/12#issuecomment-105052042 .

[mcdonnelldean]

Thought as much 😊

Kindest Regards,

Dean

On 24 May 2015, at 20:14, Matteo Collina notifications@github.com wrote:

None. Il giorno dom 24 mag 2015 alle 21:14 Dean McDonnell < notifications@github.com> ha scritto:

What impact does this have on the work I'm doing. I presume none?

Kindest Regards,

Dean

On 24 May 2015, at 20:13, Matteo Collina notifications@github.com wrote:

Ouch, then we should start updating things! :D cc @mafintosh Il giorno dom 24 mag 2015 alle 21:12 Asbjorn Enge < notifications@github.com> ha scritto:

Sorry for the late reply on this. I've been conferencing and travelling and stuff [image: :stuck_out_tongue_closed_eyes:] I have a few other things to finish up before I can look at this. But it sounds like @mcollina https://github.com/mcollina is on top if it? Levelup is @ 1.1.0 btw.

— Reply to this email directly or view it on GitHub < https://github.com/mcollina/hyperemitter/issues/12#issuecomment-105050555>

.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/mcollina/hyperemitter/issues/12#issuecomment-105052042 .

— Reply to this email directly or view it on GitHub.

[mcdonnelldean]

@mcollina I think we are still waiting on work to be done before we can touch this right?

[mcollina]

Not sure, we should try bumping level-logs to memdb 1.0.0, the. hyperlog, and then this one. Il giorno dom 14 giu 2015 alle 18:29 Dean McDonnell < notifications@github.com> ha scritto:

@mcollina https://github.com/mcollina I think we are still waiting on work to be done before we can touch this right?

— Reply to this email directly or view it on GitHub https://github.com/mcollina/hyperemitter/issues/12#issuecomment-111846425 .

[mafintosh]

memdb 1.0.0 had a bug where all instances of memdb would share the same data. this is fixed in memdb 1.0.1 so you should try that one and see if it fixes your issues

[mcollina]

I noticed that, but memdb 1.0.1 here lead to some issues with the order of things that made tests crash/hyperemitter not working. We need to investigate this more anyway.

[mcdonnelldean]

Ok I'll let ye both figure that end of it out before updating here :+1: