Closed LinusU closed 9 years ago
Hey @LinusU Thanks a mill for the PR, I'll take a look at the build error, it's most likely on our end, I'll merge once I get that sorted. Again, Awesome work, thanks!
@LinusU Yup, on our end. I'll talk to @mcollina on our end about sorting that, either way This looks good and I'll keep an eye out for it happening again until Standard gets updated.
The build error is because leveldown
doesn't work with iojs 3.0 which was recently released. This package is depending on level
which in turn depends on leveldown
. Since your travis yml specifies iojs
it switched to 3.0 when it was released.
It was fixed yesterday in levldown master, they will probably cut a new release soon. Commit: ff8a40b
Nice, thank you for the quick pull! :beers:
@LinusU No, thank you, see this is the sort of reason I love Standard. Yeah we have an outstanding PR about it on checking. As soon as that get's released we should be good. I've had a giggle though at the thought of a module breaking whitespace bug :D
Can we get this in a tune .travis.yml to not check on iojs-v3? This is possible. Leveldown 1.4.1 was released some days ago, so probably we should get that fixed anyway.
But, let's merge this.
I have updated level and memdb, can you please get this in, @mcdonnelldean?
@mcollina Just so you know, this patch is already merged :) maybe you are referring to #20 thought?
@LinusU this was reverted by @mcdonnelldean in #19
Aha, ehh, I don't understand why thought? You master branch is still failing on travis. Here is the report for the revert commit: https://travis-ci.org/mcollina/hyperemitter/builds/75677296
The problem isn't any code changes, it's just that travis upgraded their version of iojs to 3.0.
@LinusU I accidentally reverted, my bad, I then made another to reopen so I had a note for @mcollina. It's all good on your end :dancer:
@mcdonnelldean just let me know when its's in so that I release a new version.
@mcollina Will do
Sorted as of #21
All reverts have been reverted too, @LinusU We are now marked as done again, sorry about that.
No problem, thank you :+1:
We are in the process of adding back the rule
padded-blocks
intostandard
. It was temporarily disabled because of a bug in eslint which now has been fixed.This pull request makes sure that your coding style is compliant with the new version.
Please see feross/standard#170 for more info.