search

mcollina / hyperemitter

Horizontally Scalable EventEmitter powered by a Merkle DAG
ISC License
70 stars 2 forks source link

Contrib updates #25

Closed mcdonnelldean closed 9 years ago

mcdonnelldean commented 9 years ago

@mcollina Not sure why we are erroring now, @feross contrib passed tests and this is just a doc update.

feross commented 9 years ago

Oh sorry, standard is temporarily depending on eslint master until the next version is released to npm. For some reason the npm version that is bundled with node 0.10 doesn't understand how to install http git dependencies.

feross commented 9 years ago

Discussed with the eslint folk on Gitter and they should be able to do a release by Friday, maybe sooner. In the meantime, sorry for breaking node 0.10 tests.

mcdonnelldean commented 9 years ago

@feross No Problem, @mcollina should I leave this open until the new version of eslint drops?

mcollina commented 9 years ago

I think we should drop 0.10 for this module. Being backward compatible is not really important here, we want to do mad science.

mcdonnelldean commented 9 years ago

+1 our target audience is most likely not using 0.10.x I'll commit this later

Kindest Regards,

Dean

On 18 Sep 2015, at 13:51, Matteo Collina notifications@github.com wrote:

I think we should drop 0.10 for this module. Being backward compatible is not really important here, we want to do mad science.

— Reply to this email directly or view it on GitHub.

feross commented 9 years ago

The issue should be fixed now, just FYI. On Fri, Sep 18, 2015 at 6:42 AM Dean McDonnell notifications@github.com wrote:

Merged #25 https://github.com/mcollina/hyperemitter/pull/25.

— Reply to this email directly or view it on GitHub https://github.com/mcollina/hyperemitter/pull/25#event-413232377.

mcdonnelldean commented 9 years ago

@feross Awesome, we killed of 0.10.x support but good to know!