search

mcollina / mqtt-level-store

Store your in-flight MQTT message on Level, for Node
MIT License
24 stars 11 forks source link

[proposal]replacing level-browserify with level #16

Closed redboltz closed 3 years ago

redboltz commented 5 years ago

https://github.com/Level/level-browserify is deprecated now. The readme said that they recommend to replace to https://github.com/Level/level

I've replaced on my local environment and works well but level requires Node.js 8+. I personally think that Node 8+ is good enough. AWS lambda supports Node 8.10 https://aws.amazon.com/about-aws/whats-new/2018/04/aws-lambda-supports-nodejs/?nc1=h_ls

Current .travis.yml supports older version. https://github.com/mcollina/mqtt-level-store/blob/master/.travis.yml

If we can remove old version support, I will send a pull request to replace level-browserify with level.

What do you think?

mcollina commented 5 years ago

Go for it!

Il giorno mar 14 mag 2019 alle 14:16 Takatoshi Kondo < notifications@github.com> ha scritto:

https://github.com/Level/level-browserify is deprecated now. The readme said that they recommend to replace to https://github.com/Level/level

I've replaced on my local environment and works well but level requires Node.js 8+. I personally think that Node 8+ is good enough. AWS lambda supports Node 8.10 https://aws.amazon.com/about-aws/whats-new/2018/04/aws-lambda-supports-nodejs/?nc1=h_ls

Current .travis.yml supports older version. https://github.com/mcollina/mqtt-level-store/blob/master/.travis.yml

If we can remove old version support, I will send a pull request to replace level-browserify with level.

What do you think?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mcollina/mqtt-level-store/issues/16?email_source=notifications&email_token=AAAMXYYQLILAKP7BG6NDANTPVKUS5A5CNFSM4HMZKKSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GTVDCKQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAMXY5TVZGH2MBDFXGKNWLPVKUS5ANCNFSM4HMZKKSA .

redboltz commented 5 years ago

Thanks. I sent #17.

redboltz commented 3 years ago

Implemented by #17.