search

mcollina / msgpack5

A msgpack v5 implementation for node.js, with extension points / msgpack.org[Node]
MIT License
492 stars 76 forks source link

Decoder refactoring #100

Closed thephoenixofthevoid closed 3 years ago

thephoenixofthevoid commented 3 years ago

Mostly move functions out of closure Also inlined "inRange"

thephoenixofthevoid commented 3 years ago

It's very strange that merged commits are shown as mine. There are only 

Merge remote-tracking branch 'upstream/master'
Move some functions out of closure
Create context to hold options
move decodeSigned out of closure
move most of the functions out the closure
Inline InRange

that were written by me.

If I have to do something to fix this, let me know.

mcollina commented 3 years ago

I'm not sure what's the problem. I would recommend to fix the github history. I won't be able to merge this as-is.

thephoenixofthevoid commented 3 years ago

Could you please give a link on how to do that?