search

mcollina / msgpack5

A msgpack v5 implementation for node.js, with extension points / msgpack.org[Node]
MIT License
492 stars 76 forks source link

SharedArrayBuffer warning in Chrome #102

Open nheapsspreadco opened 3 years ago

nheapsspreadco commented 3 years ago

Hi!

Recently upgraded to version 5.3.2 and now getting the following warning in Chrome:

image

It seems that in msgpack5.js there is code that checks for SharedArrayBuffer, but it doesn't actually use it as part of the functionality.

Chrome version 91 (yet to be released) will apparently require a web page to be cross-origin isolated, requiring the use of new response headers, etc. Only sites modified as such will be able to use SharedArrayBuffer.

I have tried our site in Chrome DEV version 91, and all appears fine - in fact, it seems that the msgpack library no longer makes any checks on SharedArrayBuffer in this context.

May I please ask if there is an intention to use SharedArrayBuffer in earnest in the future, or will the msgpack5 library always gracefully "degrade"?

Many thanks,

Nick

mcollina commented 3 years ago

I don't have a clue why we are using it for that, so I'm up for removing if you'd like to send a PR?

Donov4n commented 3 years ago

Any news on this ?

mcollina commented 3 years ago

Any news on this ?

Would you like to send a PR?