Bumping tape version - Githubissues

mcollina / msgpack5

A msgpack v5 implementation for node.js, with extension points / msgpack.org[Node]

MIT License

493 stars 76 forks source link

Bumping tape version #23

Closed moonglum closed 9 years ago

moonglum commented 9 years ago

Updated the tape version
The test command did not use the locally installed version of tape and faucet, so it did not work when you did not install those globally.

mcollina commented 9 years ago

Thanks for bumping the tape version.

The test command does not need node_modules, as it wires things up that all modules that installs a binary can be used in the scripts. So, why do you need that change?

moonglum commented 9 years ago

When I run npm test without this change, I will get an error that the command "tape" was not found.

mcollina commented 9 years ago

which version of node/npm are you using?

mcollina commented 9 years ago

As you can see in the Travis build, there is no global installation of tape and faucet. https://travis-ci.org/mcollina/msgpack5/jobs/61466837

moonglum commented 9 years ago

Ok, maybe it is because I have older versions of Node and NPM?

Node v0.10.26
NPM 1.4.3

But this makes it work on those old versions, too – and apart from that command everything works in 0.10 :wink:

mcollina commented 9 years ago

Current master npm test runs smoothly on node v0.10.26.

moonglum commented 9 years ago

Weird. Let me test it again.

moonglum commented 9 years ago

Weird... It works now. Sorry for the confusion, I removed everything apart from the version bump!

mcollina commented 9 years ago

Thanks!!

moonglum commented 9 years ago

You're welcome!