search

mcollina / msgpack5

A msgpack v5 implementation for node.js, with extension points / msgpack.org[Node]
MIT License
492 stars 76 forks source link

add forceFloat64 flag to encoder #31

Closed hden closed 9 years ago

hden commented 9 years ago

fix https://github.com/mcollina/msgpack5/issues/30

Should we expose flags e.g. avoidSlice, forceFloat64 to top-level namespace?

e.g. var msgpack = require('msgpack5')({ avoidSlice: false, forceFloat64: true })

mcollina commented 9 years ago

I think forceFloat64 needs to be only at top level, it's not something really specific to any encoding. Regarding avoidSlice, I am not even sure why it ended up in there: it can probably be removed.

Can you also document forceFloat64 in the README?

hden commented 9 years ago

@mcollina Any update on this?

mcollina commented 9 years ago

Sorry, GH does not send a notification when a commit is made on a PR.

Released as 3.1.0

hden commented 9 years ago

thanks!