search

mcollina / msgpack5

A msgpack v5 implementation for node.js, with extension points / msgpack.org[Node]
MIT License
492 stars 76 forks source link

Fix for #58 missing in bundled file #62

Closed analogrelay closed 6 years ago

analogrelay commented 6 years ago

The fix for #58 appears to only be present in the lib/encoder.js file in the package, not the bundled dist/msgpack5.js file.

See encoder.js:

https://github.com/mcollina/msgpack5/blob/c504ca7e1133b517ac571a7eaed57c40fc14b316/lib/encoder.js#L48-L53

Compared to msgpack5.js:

https://github.com/mcollina/msgpack5/blob/c504ca7e1133b517ac571a7eaed57c40fc14b316/dist/msgpack5.js#L534-L536

Sounds like maybe the bundle just hasn't been updated 😄

mcollina commented 6 years ago

Fixed in 4.0.1.