build dist for browserify

[i5ting]

add dependency

• browserify
• uglify-js

in package.json ,add scripts command for build

npm run build

and this will be add

• dist/msgpack5_bundle.js
• dist/msgpack5_bundle.min.js

i've no find contribute guide, please check if this is a appropriate pull request

[mcollina]

Thanks for remembering that I have to add a contribution rule to this project ;). I'm being lazy.

Anyway, I think it would be awesome if you could contribute also zuul or testling support, so that we can verify that the tests passes in the browser too.

[mcollina]

I've added a contributing file. I have also added a needed feature and I'm going to release it in the next few days. Are you going to add the test harness support, so I release both?

[i5ting]

i'm glad to add the zuul test support , thanks for your patience

[mcollina]

any update on this?

[i5ting]

1..3822
# tests 3822
# pass  3790
# fail  32

npm ERR! msgpack5@1.3.5 test-browser: `browserify  -r bl:inherits:readable-stream test/* | testling`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the msgpack5@1.3.5 test-browser script.
npm ERR! This is most likely a problem with the msgpack5 package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     browserify  -r bl:inherits:readable-stream test/* | testling
npm ERR! You can get their info via:
npm ERR!     npm owner ls msgpack5
npm ERR! There is likely additional logging output above.
npm ERR! System Darwin 13.3.0
npm ERR! command "node" "/usr/local/bin/npm" "run" "test-browser"
npm ERR! cwd /Users/sang/workspace/github/msgpack5
npm ERR! node -v v0.10.31
npm ERR! npm -v 1.4.23
npm ERR! code ELIFECYCLE
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/sang/workspace/github/msgpack5/npm-debug.log
npm ERR! not ok code 0

there's 32 failed test, i try to find which cause it

[i5ting]

# concatenated buffers work
not ok 3821 TypeError: 'undefined' is not a function (evaluating 'bl.append.bind(bl)')
  ---
    operator: error
    expected:
      undefined
    actual:
      { [TypeError: 'undefined' is not a function (evaluating 'bl.append.bind(bl)')] message: '\'undefined\' is not a function (evaluating \'bl.append.bind(bl)\')', line: 16233, sourceId: 171874896, sourceURL: 'http://localhost:53442/__testling?show=true', stack: 'TypeError: \'undefined\' is not a function (evaluating \'bl.append.bind(bl)\')\n    at http://localhost:53442/__testling?show=true:16233\n    at bound (http://localhost:53442/__testling?show=true:13130)\n    at http://localhost:53442/__testling?show=true:13144\n    at bound (http://localhost:53442/__testling?show=true:13130)\n    at next (http://localhost:53442/__testling?show=true:12943)\n    at http://localhost:53442/__testling?show=true:9820', stackArray: [ { line: 16233, sourceURL: 'http://localhost:53442/__testling?show=true' }, { function: 'bound', line: 13130, sourceURL: 'http://localhost:53442/__testling?show=true' }, { line: 13144, sourceURL: 'http://localhost:53442/__testling?show=true' }, { function: 'bound', line: 13130, sourceURL: 'http://localhost:53442/__testling?show=true' }, { function: 'next', line: 12943, sourceURL: 'http://localhost:53442/__testling?show=true' }, { line: 9820, sourceURL: 'http://localhost:53442/__testling?show=true' } ] }
    stack:
      TypeError: 'undefined' is not a function (evaluating 'bl.append.bind(bl)')
        at http://localhost:53442/__testling?show=true:16233
        at bound (http://localhost:53442/__testling?show=true:13130)
        at http://localhost:53442/__testling?show=true:13144
        at bound (http://localhost:53442/__testling?show=true:13130)
        at next (http://localhost:53442/__testling?show=true:12943)
        at http://localhost:53442/__testling?show=true:9820
  ...
not ok 3822 plan != count
  ---
    operator: fail
    expected: 3
    actual:   1
  ...

it seems with bl npm,but i already require it

   "test-browser": "browserify  -r bl:inherits:readable-stream test/* | testling"

....

[mcollina]

Can you please send over a PR with the test harness in place? Something I can run with npm run test-browser?

Also what is the file/line of that call? Il giorno lun 15 dic 2014 alle 07:30 alfred sang notifications@github.com ha scritto:

concatenated buffers work

not ok 3821 TypeError: 'undefined' is not a function (evaluating 'bl.append.bind(bl)')

---

operator: error
expected:
  undefined
actual:
  { [TypeError: 'undefined' is not a function (evaluating 'bl.append.bind(bl)')] message: '\'undefined\' is not a function (evaluating \'bl.append.bind(bl)\')', line: 16233, sourceId: 171874896, sourceURL: 'http://localhost:53442/__testling?show=true', stack: 'TypeError: \'undefined\' is not a function (evaluating \'bl.append.bind(bl)\')\n    at http://localhost:53442/__testling?show=true:16233\n    at bound (http://localhost:53442/__testling?show=true:13130)\n    at http://localhost:53442/__testling?show=true:13144\n    at bound (http://localhost:53442/__testling?show=true:13130)\n    at next (http://localhost:53442/__testling?show=true:12943)\n    at http://localhost:53442/__testling?show=true:9820', stackArray: [ { line: 16233, sourceURL: 'http://localhost:53442/__testling?show=true' }, { function: 'bound', line: 13130, sourceURL: 'http://localhost:53442/__testling?show=true' }, { line: 13144, sourceURL: 'http://localhost:53442/__testling?show=true' }, { function: 'bound', lin

e: 13130, sourceURL: 'http://localhost:53442/__testling?show=true' }, { function: 'next', line: 12943, sourceURL: 'http://localhost:53442/__testling?show=true' }, { line: 9820, sourceURL: 'http://localhost:53442/__testling?show=true' } ] } stack: TypeError: 'undefined' is not a function (evaluating 'bl.append.bind(bl)') at http://localhost:53442/__testling?show=true:16233 at bound (http://localhost:53442/__testling?show=true:13130) at http://localhost:53442/__testling?show=true:13144 at bound (http://localhost:53442/__testling?show=true:13130) at next (http://localhost:53442/__testling?show=true:12943) at http://localhost:53442/__testling?show=true:9820 ... not ok 3822 plan != count

---

operator: fail
expected: 3
actual:   1

...

it seems with bl npm,but i already require it

"test-browser": "browserify -r bl:inherits:readable-stream test/* | testling"

....

— Reply to this email directly or view it on GitHub https://github.com/mcollina/msgpack5/pull/7#issuecomment-66954646.

[mcollina]

Released as 1.4.0.