Open zheli-1 opened 3 years ago
Hi, there.
I am running an auto script testing framework and found out it might be a bug in encoder.js:
it's when encoderDate's argument is null, it throws exceptions so could a condition to avoid this.
Can you verify if it's a potential bug? it would be helpful for my experiment:)
function encodeDate (dt) { var encoded //filter if(dt === null){ return; } //zl3 var millis = dt 1 var seconds = Math.floor(millis / 1000) var nanos = (millis - (seconds 1000)) * 1E6
if (nanos || seconds > 0xFFFFFFFF) {
After adding the following line, in test scripting timestamps.js passes. I will send a pull request if necessary :)
any update?
Would you like to send a Pull Request to address this issue? Remember to add unit tests.
Hi, thanks for replying. I've sent a pull request already. I'll add unit tests for sure.
Hi, there.
I am running an auto script testing framework and found out it might be a bug in encoder.js:
it's when encoderDate's argument is null, it throws exceptions so could a condition to avoid this.
Can you verify if it's a potential bug? it would be helpful for my experiment:)
function encodeDate (dt) { var encoded //filter if(dt === null){ return; } //zl3 var millis = dt 1 var seconds = Math.floor(millis / 1000) var nanos = (millis - (seconds 1000)) * 1E6
After adding the following line, in test scripting timestamps.js passes. I will send a pull request if necessary :)