no actual performance gains on latest nodejs

mcollina / reusify

Reuse objects and functions with style

MIT License

162 stars 18 forks source link

no actual performance gains on latest nodejs #9

Closed olehdevua closed 6 years ago

olehdevua commented 6 years ago

I ran benchmark several times, so below you can see average result

mcollina commented 6 years ago

I know. However when I tried to remove it from some of the modules they slowed down in Node 8. Node 10 has a fix for the specific problem this module was needed for.

olehdevua commented 6 years ago

Ok, in such case I close the issue. Btw, can you say where I can read about the fixes/improvements in Node regards this problem, thanks in advance.

yunfan commented 5 years ago

@mcollina is that means from node 10 we dont need this module? because from what i had test , its the reverse on performance

mcollina commented 5 years ago

I've tried removing this from a couple of places and I saw a perf degradation.