mcollovati / quarkus-hilla

A Quarkus extension to run Hilla applications on Quarkus.
Apache License 2.0
15 stars 0 forks source link

fix: add support for endpoint prefix #1035

Closed mcollovati closed 1 week ago

mcollovati commented 2 weeks ago

Adds a code generator that create the connect-client.ts file if a custom endpoint prefix has been configured in application.properties.

Fixes #114

quarkus-hilla-bot[bot] commented 2 weeks ago

Format Checker Report

All files are correctly formatted

github-actions[bot] commented 2 weeks ago

Test Results

 67 files  + 8   67 suites  +8   13m 40s ⏱️ + 1m 27s 216 tests +24  215 ✅ +23  1 💤 +1  0 ❌ ±0  316 runs  +40  315 ✅ +39  1 💤 +1  0 ❌ ±0 

Results for commit 4fd5d2ad. ± Comparison against base commit 875aab2a.

:recycle: This comment has been updated with latest results.

Dudeplayz commented 2 weeks ago

One thing: Is this feature somewhere documented? Do we have documented the config properties somewhere at all? Maybe we add them directly to the readme ?

mcollovati commented 2 weeks ago

Custom prefix is a Hilla feature, but it would be good to mention automatic generation in the Readme

Dudeplayz commented 2 weeks ago

Custom prefix is a Hilla feature, but it would be good to mention automatic generation in the Readme

Generation yes. For the prefix, I meant that the possible configuration keys that are possible in the application.properties for quarkus-hilla are documented. Just as simple code block with comments e.g.

vaadin.endpoint.prefix #custom hilla prefix ...
mcollovati commented 2 weeks ago

Make sense. But I would create a new PR to document all the configuration properties.