mcollovati / quarkus-hilla

A Quarkus extension to run Hilla applications on Quarkus.
Apache License 2.0
14 stars 0 forks source link

fix: adapt to new endpoint registry initialization #622

Closed mcollovati closed 6 months ago

mcollovati commented 6 months ago

Hilla endpoint registry is now eagerly initialized in a VaadinServiceInitListener. This change introduces an custom init listener to postpone the registry initialization in a method, to prevent application crash because Quarkus SecurityConfiguration required by security interceptor (e.g. for annotation) is not yet ready.

Fixes #604

quarkus-hilla-bot[bot] commented 6 months ago

Format Checker Report

All files are correctly formatted

github-actions[bot] commented 6 months ago

Test Results

 47 files  + 27   47 suites  +27   12m 47s :stopwatch: + 10m 53s 166 tests +140  166 :white_check_mark: +166  0 :zzz:  - 9  0 :x: ±0  221 runs  +195  221 :white_check_mark: +221  0 :zzz:  - 9  0 :x: ±0 

Results for commit 95760831. ± Comparison against base commit 26cc3cd3.

This pull request removes 15 and adds 155 tests. Note that renamed tests count towards both. ``` com.github.mcollovati.quarkus.hilla.deployment.BrowserCallableControllerTest ‑ Unknown test com.github.mcollovati.quarkus.hilla.deployment.EndpointControllerTest ‑ Unknown test com.github.mcollovati.quarkus.hilla.deployment.EndpointSecurityTest ‑ Unknown test com.github.mcollovati.quarkus.hilla.deployment.ReactiveEndpointTest ‑ Unknown test com.github.mcollovati.quarkus.hilla.deployment.ReactiveSecureEndpointTest ‑ Unknown test com.github.mcollovati.quarkus.hilla.deployment.SpringDataExtensionsSupportTest ‑ Unknown test com.github.mcollovati.quarkus.hilla.deployment.SpringDiExtensionSupportReactiveEndpointTest ‑ Unknown test com.github.mcollovati.quarkus.hilla.deployment.SpringDiExtensionsSupportTest ‑ Unknown test com.github.mcollovati.quarkus.hilla.deployment.SpringReplacementsTest ‑ Unknown test com.github.mcollovati.quarkus.hilla.deployment.crud.panache.CrudRepositoryServiceTest ‑ Unknown test … ``` ``` com.example.application.AutoCrudTest ‑ autocrud_gridAndFormDisplayed com.example.application.AutoCrudTest ‑ autocrud_newUser_userSaved com.example.application.AutoCrudTest ‑ selectUser_delete com.example.application.AutoCrudTest ‑ selectUser_editAndDiscard com.example.application.AutoCrudTest ‑ selectUser_editAndSubmit com.example.application.AutoCrudTest(production) ‑ autocrud_gridAndFormDisplayed com.example.application.AutoCrudTest(production) ‑ autocrud_newUser_userSaved com.example.application.AutoCrudTest(production) ‑ selectUser_delete com.example.application.AutoCrudTest(production) ‑ selectUser_editAndDiscard com.example.application.AutoCrudTest(production) ‑ selectUser_editAndSubmit … ```
github-actions[bot] commented 6 months ago

This issue has been resolved in 24.0.0-alpha2 (Release Notes)