search

mcollovati / vertx-vaadin

Run Vaadin UI on Vert.x
MIT License
44 stars 17 forks source link

Create branch for vaadin 10 support #4

Closed mcollovati closed 5 years ago

mcollovati commented 6 years ago

Instead of a separated branch consider creating three separated projects:

At every release all three artifacts will be produced and deployed with the same version. Mostly depends on how many changes are required in router configuration for Vaadin 10

davidsowerby commented 6 years ago

Having three libraries is a good idea I think. I'm not sure about trying to keep the versions the same ... I understand the desire to do that, but the Vaadin 10 branch will change more frequently than the others - so you will be changing the version of vertx-vaadin8 and vertx-vaadin-common when nothing has actually changed in them. Dependency management (Maven / Gradle) will take care of differing version numbers.

mcollovati commented 6 years ago

I think you're right; in this case having separated version would be a better choice.

My thought was that having a single version would simplify the automation of deployment process; but for now I think I can do it manually :smile:

petarov commented 5 years ago

@mcollovati Is this still on your TODO list? I'd love to see a vaadin10 support. 😉

mcollovati commented 5 years ago

@petarov This is definitely on TODO list

I already have a local branch for Vaadin 10, but I had some troubles with the integration, and then I didn't had enough time to dedicate to this project.

I hope to start working again on it in the next months

mcollovati commented 5 years ago

@petarov a first version of Vaadin 10 support is available on ISSUE-4/vaadin-10-support branch

petarov commented 5 years ago

Super cool! I'll play with it this week and get back to you.

mcollovati commented 5 years ago

Great, thanks. Here's a link to vaadin sample app running on vertx

https://vertx-vaadin10-example.herokuapp.com/

mcollovati commented 5 years ago

Stuff for Vaadin flow merged into master