Links between PRs and issues not appearing - Githubissues

mcomella / apt_github_improvements

A browser extension to add features to GitHub for the Android Product Team (APT) at Mozilla

Mozilla Public License 2.0

3 stars 0 forks source link

Links between PRs and issues not appearing #33

Closed severinrudie closed 6 years ago

severinrudie commented 6 years ago

Links from issue to PR, and links from PR to issue are not appearing. I am reproducing this ~90% of the time.

We found the following error in my logs: TypeError: storedIssueToPRs[key] is not iterable

mcomella commented 6 years ago

Looks like this is the section: https://github.com/mcomella/apt_github_improvements/blob/348cec773df32f90572d2192c7a9be75e0588e22/src/contentScript/github/githubStore.ts#L57-L63

mcomella commented 6 years ago

Theories:

We're storing bad data in the DB
for (const key in storedIssueToPRs) {} is iterating over non-key properties of the returned value; these are not expected but theoretically not impossible
storage.get on a key without a value will return an object with {key: undefined}

mcomella commented 6 years ago

We're storing a Set in the DB: the docs say it can only store primitives and arrays. Also, we (I think) we previously got burned in #30 for storing non-primitive types in the db that seemed to work in testing so this is the likely culprit.

mcomella commented 6 years ago

@Baron-Severin I made a speculative fix as I am unable to reproduce. After upgrading, please let me know if you see the issue again!

mcomella commented 6 years ago

This is fixed in v0.5.1.