search

mconf / bigbluebutton-api-ruby

BigBlueButton API gem for Ruby
Other
49 stars 42 forks source link

Exception should not be used for CustomErrors, replacing it with StandardError #42

Closed h0jeZvgoxFepBQ2C closed 2 years ago

h0jeZvgoxFepBQ2C commented 4 years ago

Please don't use Exception for application errors, it can't be rescued in a normal catch block... See here for best practices: https://www.honeybadger.io/blog/ruby-exception-vs-standarderror-whats-the-difference/

h0jeZvgoxFepBQ2C commented 4 years ago

Would be great if anyone take a look at this PR and merge it if it's fine?

h0jeZvgoxFepBQ2C commented 4 years ago

Is there any chance this PR gets accepted?