mconf / bigbluebutton

BigBlueButton is an open source web conferencing system for distance education
www.bigbluebutton.org
40 stars 33 forks source link

Shared notes out of sync #266

Closed mconf-daileon closed 8 years ago

mconf-daileon commented 8 years ago

Author Name: Pedro Beschorner Marin (Pedro Beschorner Marin) Original Redmine Issue: 1716, http://dev.mconf.org/redmine/issues/1716 Original Date: 2015-08-04 Original Assignee: Pedro Beschorner Marin


This bug was described as it follows: At Mconf Live 0.6.3 RNP branch. Some users experienced joining a meeting without getting his shared notes updated with the server's data. This generates a failure state that could erase others users notes if this client started writing in his unsynchronized note.

mconf-daileon commented 8 years ago

Original Redmine Comment Author Name: Pedro Beschorner Marin (Pedro Beschorner Marin) Original Date: 2015-08-04T16:01:58Z


When trying to reproduce this bug, we got a similar problem commenting this line at the client: https://github.com/mconf/bigbluebutton-cs/blob/mconf-live0.6.3-rnp/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/maps/SharedNotesEventMap.mxml#L57 This forced the notes to be out of sync.

mconf-daileon commented 8 years ago

Original Redmine Comment Author Name: Pedro Beschorner Marin (Pedro Beschorner Marin) Original Date: 2015-08-04T19:09:34Z


Kind of solution. If the problem was in fact the currentDocument message not reaching the client, this will disable the buggy client from the shared notes so he can't mess with other users valid notes. To try to fix the missing of notes data I'm listening to the shared notes focus and triggering another getCurrentDocument message. How about it? Can we make this in a more elegant way? Maybe the focus can be replaced with a timer or something like it.

https://github.com/pedrobmarin/bigbluebutton/tree/fix-issue-1716

mconf-daileon commented 8 years ago

Original Redmine Comment Author Name: Leonardo Daronco (Leonardo Daronco) Original Date: 2015-09-23T18:52:28Z


Issue #1716 has been updated by Felipe Cecagno.

Status changed from Feedback to Resolved % Done changed from 90 to 100

Merged https://github.com/mconf/bigbluebutton/commit/ac4f58c997237d3c67d8f58f2938cf1864e02fa7