search

mconf / bigbluebutton

BigBlueButton is an open source web conferencing system for distance education
www.bigbluebutton.org
40 stars 33 forks source link

When a user uses text selection on empty lines his modifications get out of sync with other users. #272

Closed mconf-daileon closed 8 years ago

mconf-daileon commented 8 years ago

Author Name: Leonardo Daronco (Leonardo Daronco) Original Redmine Issue: 1742, http://dev.mconf.org/redmine/issues/1742 Original Date: 2015-09-23 Original Assignee: Pedro Beschorner Marin

[Originally by Pedro Beschorner Marin]

author:

a

reader:

a
mconf-daileon commented 8 years ago

Original Redmine Comment Author Name: Leonardo Daronco (Leonardo Daronco) Original Date: 2015-09-23T18:12:46Z

Issue #1742 has been updated by Pedro Beschorner Marin.

The only way I could resolve this was using a regex replace at the sender's side so the unwanted flags are automatically removed. If someone has a better idea how to fix this, it would be great. We need to make some better testing with more users.

mconf-daileon commented 8 years ago

Original Redmine Comment Author Name: Pedro Beschorner Marin (Pedro Beschorner Marin) Original Date: 2015-10-01T18:41:04Z

The regex was reverted some time ago. Was affecting user's text style status.

The last modification is in this branch: https://github.com/pedrobmarin/bigbluebutton-cs/tree/mconf-live0.7.3-rnp

Rafael and I had to 'rewrite' the RichTextEditor component. The problem remains between font type, color and size when they share the same paragraph.

mconf-daileon commented 8 years ago

Original Redmine Comment Author Name: Pedro Beschorner Marin (Pedro Beschorner Marin) Original Date: 2015-10-02T13:14:50Z

A few extra changes had to be made here. The same problem as the bold example above happens with other formatting tools. Italic, bold and underline were corrected the same way. User wont be able to mark an empty line with those tools and neither preserve this format when 'enter' key is pressed.

Another fix I made is related with the same problem but works in a different way. Font type, color and size should always be managed in here "". This should avoid a lot of sync issues. The down side of this is that whole paragraphs will receive the same font type (not that bad), size (not that bad) and color (ok, this can be a really downer). In other words, they will work as text align works.

I believe this is what we can do using flash as a rich text editor. We can try to dig deeper on those things but I think this should be a client's decision.

mconf-daileon commented 8 years ago

Original Redmine Comment Author Name: Rafael Petersen (Rafael Petersen) Original Date: 2015-10-16T20:44:33Z

Improved the Shared Notes window to properly support mouse Context Menu Paste (was an issue, would not trigger the formatting corrections for pasted data). Solved a bug where pasted text would cause kerning to change and eventually cause loss of consistency. Kerning would become a nested tag, breaking consistency when left empty.

Link to full modification comparison: https://github.com/mconf/bigbluebutton-cs/compare/mconf-live0.7.3-rnp...RafaFP:mconf-live0.7.3-rnp?expand=1