Handling presentation tab change through keyboard shortcuts

mconf / bigbluebutton

BigBlueButton is an open source web conferencing system for distance education

www.bigbluebutton.org

40 stars 33 forks source link

Handling presentation tab change through keyboard shortcuts #375

Closed alexandrekreis closed 7 years ago

alexandrekreis commented 7 years ago

There were 2 issues:

Flash was letting invisible tabs be accessed through keyboard shortcuts. We have to disable the invisible tabs as well.
TabNavigator does not update the selectedIndex when the tab change is made through a keyboard shortcut. We have to get the correct index using TabBar and mouse event informations.

pedrobmarin commented 7 years ago

There is also other presentation's shortcuts that may cause problems. The presenter can use the arrow keys and custom context box options to change slides. This should be disabled when sharing desktop to avoid recording errors.

pedrobmarin commented 7 years ago

And maybe this can be separated in a new method since we use it seven times just in this file: presenterTabs.getTabAt(TAB_INDEX).visible = STATUS; presenterTabs.getTabAt(TAB_INDEX).includeInLayout = STATUS; presenterTabs.getTabAt(TAB_INDEX).enabled = STATUS;