search

mcongrove / ChariTi

Please do not use: this is out-dated
Other
113 stars 85 forks source link

Support Android back-button #123

Closed FokkeZB closed 11 years ago

FokkeZB commented 11 years ago

Since the app runs in one heavy window, hitting the hardware back-button on Android devices causes the app to exit.

I'm making changes to core.js to capture the android:back event and see if there are any child screens to close. Only when they're no child windows left to close, the app should exit.

mcongrove commented 11 years ago

GitHub needs a "Like" button.

EDIT: Found it :+1:

mcongrove commented 11 years ago

Any update on progress?

FokkeZB commented 11 years ago

Hi Matthew,

I've got it working for the main tabs in handheld view. What's left to do is get it working on split views and non-tab views like the settings one. That and exit the app if there's no step to go back to. Shouldn't be to hard, but I'm having two jobs at the moment, so my time is limited.

I'll post whatever I get to today.

Fokke

Op 9 feb. 2013, om 02:10 heeft Matthew Congrove notifications@github.com het volgende geschreven:

Any update on progress?

— Reply to this email directly or view it on GitHub..

mcongrove commented 11 years ago

Oh, I totally understand. Not trying to rush, just trying to gauge timelines :)

FokkeZB commented 11 years ago

Glad you fixed it and sorry I couldn't be of any help. It's very hectic here and that probably won't change before April :(

mcongrove commented 11 years ago

Hey, no problem! We ended up going in and refactoring a bunch of stuff as it related to view stacking, and I realized once that was done it was super easy to just go ahead and knock this bug out.

Thanks for filing it in the first place!