search

mcongrove / ChariTi

Please do not use: this is out-dated
Other
113 stars 85 forks source link

1.1.1 #161

Closed sjardim closed 11 years ago

sjardim commented 11 years ago

Podcast Offline Listening

Now it's possible to download the mp3 while listening and save it to the local storage (external storage for Android). The app will use the offline file (if it exists) when playing, so it know works when offline.

mcongrove commented 11 years ago

Thanks so much for this pull request!

I'll look it over in the next couple of days and merge it in.

mcongrove commented 11 years ago

There's a lot of additional stuff in here, including changes to the text tab XML, etc. Also, the favorite button (and what seems like an un-used favorite button widget). That's fine, though, as I can just hand-copy out the bits we need.

There also needs to be a button to let the user decide if they want to download the file or not. I'll add this in the next UI update, when we add support for iOS 7.

Thanks again for coming up with this solution... can't wait to integrate it :)

sjardim commented 11 years ago

Yep, I'm continuing working on this favorite function as it is a very important feature to my app. As I'm just learning Titanium as I code (and I'm more a designer than a developer) there is a lot of mess in there, so be careful! ;-)

This button to decide about the download will be great! Thank you for the all hard work and this great app!

Important: I have not tested the download function on Android yet because I (stupidly) downloaded Google's SDK update before Titanium got support.

mcongrove commented 11 years ago

No worries, we do thorough testing cross-platform before any feature commits :) Thanks again for the idea, and keep 'em coming!

mcongrove commented 11 years ago

Closing this PR as we integrated most of the code; remaining fixes are now logged in Issue #166.