search

mcongrove / ChariTi

Please do not use: this is out-dated
Other
113 stars 85 forks source link

app.json download #170

Closed countrdd closed 11 years ago

countrdd commented 11 years ago

I believe there is a bug in the core.js. Specifically this line. APP.ConfigurationURL = data.configurationUrl && data.configurationUrl.length > 10 ? data.configurationUrl : false;

should it not be

APP.ConfigurationURL = data._configurationUrl && data._configurationUrl.length > 10 ? data._configurationUrl : false;

i.e. configurationURL should have a _ before it.

mcongrove commented 11 years ago

Hey,

Actually, the configuration URL is essentially being commented out by adding the underscore. It makes developing and testing incredibly hard when the JSON config file is cached :)

Thanks for pointing that out, though... it should be enabled in the Git repo so people who download it have no problems. :+1: The same goes for the 'manifest' element.