mcongrove / ChariTi

Please do not use: this is out-dated
Other
113 stars 85 forks source link

Tab Menu covers the bottom of active views #188

Closed Aaron-Hartwig closed 10 years ago

Aaron-Hartwig commented 10 years ago

If you're using the tab menu rather than the slide menu, all the views associated with the tabs run behind the tabs. This means you cannot read the bottom of some table views, scroll views, or reach content located at the very bottom of the page. screen shot 2013-10-18 at 3 06 57 pm

mcongrove commented 10 years ago

Probably has to do with the scroll-under I added for iOS7. Need to check the wrappers (global wrapper, content wrapper, and wrapper for each component) and see which one has the wrong setting. We'll probably have to dynamically add a 'bottom' to a wrapper if there's a tab bar, or leave it un-touched if it's using the slide menu.

rogerwhite commented 10 years ago

@Aaron-Hartwig : This is how I fixed mine. Works but you have to do this on every file that has the issue. Tried to find a global way of accessing "container" but can't seem to find one.

Adding a "bottom" value to "container" works.

For Example (facebook.js):

if(APP.Settings.useSlideMenu) {
    $.NavigationBar.showMenu();
} else {
    $.NavigationBar.showSettings();
    $.container.bottom = "60dp"; //added fix for semi-hidden content on tab view
}
rogerwhite commented 10 years ago

@Aaron-Hartwig @mcongrove : podcast_podcast..tss

"#content": { top: "0dp" },

Should be :

"#container": { top: "0dp" },

semencov commented 10 years ago

It looks like the question is about the tss:

Content wrapper's id differs in both index.tss and index.xml:

index.tss:

"#containerWrapper": {
  top: "0dp",
  bottom: "60dp"
}

index.xml:

<Alloy>
  <Window id="MainWindow">
    <Require type="widget" src="com.chariti.slideMenu" id="SlideMenu" />

    <View id="GlobalWrapper">
      <View id="ContentWrapper" />

      <Require type="widget" src="com.chariti.tabs" id="Tabs" />
    </View>
  </Window>
</Alloy>

Replacing #containerWrapper with the #ContentWrapper fixed the issue for me.

rogerwhite commented 10 years ago

@semencov Perfect! That was it.

mcongrove commented 10 years ago

Thanks @semencov for the fix, and @Aaron-Hartwig for the report!

mcongrove commented 10 years ago

@rogerwhite Thanks for the podcast_podcast.tss report, fixed by 03f0b9d9274b9fa6a09518feb58eb5b23068c865