search

mcongrove / ChariTi

Please do not use: this is out-dated
Other
113 stars 85 forks source link

Issue #160 slide menu headers #192

Closed Aaron-Hartwig closed 10 years ago

Aaron-Hartwig commented 10 years ago

A more refined attempt at a menu header system.

mcongrove commented 10 years ago

@joshjensen Thoughts? Ignore the first two commits in this PR, as he re-codes most of that stuff. The last three are the important ones.

From my initial impression it looks good; I'll take a closer look tomorrow.

joshjensen commented 10 years ago

Hey guys, it's a great addition and it looks good. My one comment, and maybe I am missing something, but why is the home title a different color from the "social" and "help us" titles?

https://www.evernote.com/shard/s9/sh/85908c8e-63a6-43c1-8871-46d1d19adc5c/a78b673c969de91d58880652c74a8e43/deep/0/Untitled%20note.jpg

Is the top one intended to be a different color?

Aaron-Hartwig commented 10 years ago

@joshjensen it seems that you are building a previous version there. That was the in the earlier stages of this feature. Notice how the header text is left aligned rather than being flush with the rest of the labels? Unless I am mistaken, this is what it should look like: screen shot 2013-10-30 at 8 43 35 am

joshjensen commented 10 years ago

Ah nice, must have been my mistake. That's what I was expecting, it looks great! Thanks for the clarification.

-Josh

Aaron Hartwig mailto:notifications@github.com October 30, 2013 9:47 AM

@joshjensen https://github.com/joshjensen it seems that you are building a previous version there. That was the in the earlier stages of this feature. Notice how the header text is left aligned rather than being flush with the rest of the labels? Unless I am mistaken, this is what it should look like: screen shot 2013-10-30 at 8 43 35 am https://f.cloud.github.com/assets/5115774/1437212/ca1d17a8-4169-11e3-92e5-a162cd8c080b.png

— Reply to this email directly or view it on GitHub https://github.com/mcongrove/ChariTi/pull/192#issuecomment-27389957.

Aaron Hartwig mailto:notifications@github.com October 29, 2013 11:00 PM

A more refined attempt at a menu header system.

    You can merge this Pull Request by running

git pull https://github.com/Aaron-Hartwig/ChariTi 1.2.0

Or view, comment on, or merge it at:

https://github.com/mcongrove/ChariTi/pull/192

    Commit Summary
mcongrove commented 10 years ago

It's in there! Thanks again, @Aaron-Hartwig !

patel-pragnesh commented 10 years ago

great.. thanks to Aaron-Hartwig !