mcoot / TribesLauncherSharp

C# implementation of TribesLauncher
GNU Affero General Public License v3.0
23 stars 7 forks source link

TribesLauncher considers tribes ascend server a valid injection target #2

Open Griffon26 opened 5 years ago

Griffon26 commented 5 years ago

When the TribesLauncher is started and there is already a TribesAscend.exe running as a server, TribesLauncher sees it as a valid injection target. This has a number consequences:

mcoot commented 5 years ago

This actually already has a solution... which is not exposed by the UI. In the launcherconfig.yaml file, there is an InjectByProcessId flag which is false by default. If you set it to true, the launcher will inject into only the process ID it launched.

I added this feature mainly for my own testing - where I often need both a server and client running.

It is not exposed because it's not relevant to the usual user use case, and injecting by process ID means you can't start the game externally and then inject.

Griffon26 commented 5 years ago

Could you instead look at the command line the process was started with and automatically exclude server processes? That'll take care of the most common use case without needing InjectByProcessId. The latter you could still use if you have 2 clients.

mcoot commented 5 years ago

That's a good point; I'll set that up when I'm next working on the launcher.

At some point I want to rework the launcher UI to separate things into tabs, but it's not top priority.