search

mcorning / lct-c

1 stars 3 forks source link

Containers: Are we using them on heroku properly? #9

Open mcorning opened 3 years ago

mcorning commented 3 years ago

the first thing that worries me is my uncertainty around linking to github.

for containers, we are supposed to git push heroku master:master

this then triggers heroku to build the container.

but i just linked lct-c2 to the lct-c github repo, and checkins trigger an app build, as expected. but does this put the app in a different state than the container?

second, are we using containers so that we don't need to rebuild node_modules all the time. would volumes be the right thing to use for node_modules?

mcorning commented 3 years ago

this may be a good guide for the vue part of lct: awesome-compose/vuejs/