mcostalba / chess_db

GNU General Public License v3.0
22 stars 5 forks source link

"No valid games found!" not handled in chess_db.py #29

Closed gbtami closed 7 years ago

gbtami commented 7 years ago

If a .pgn has only variant games self.p.expect(BOOK_MAKE_DONE_REGEX) is waiting forever now.

sshivaji commented 7 years ago

What should the regex be then? Do you have a variant games file and the output of the command?

We can support more than one regex with self.p.expect([BOOK_MAKE_REGEX, VARIANT_MAKE_REGEX])

gbtami commented 7 years ago

Yes it's in #32

mcostalba commented 7 years ago

Already fixed upstream at lower level.