Fix issue #33 Inconsistent ply returnd by scout

mcostalba / scoutfish

Chess Query Engine

GNU General Public License v3.0

156 stars 23 forks source link

Fix issue #33 Inconsistent ply returnd by scout #37

Closed gbtami closed 7 years ago

gbtami commented 7 years ago

Modification of test.py drops tedious work of regenerating signatures and adds the ability to report exact reasons of failed test cases also. Dropped get_games() and get_headers() tests as they are testing nothing from scoutfish. These two Python method in scoutfish.py should be moved to some usage example script IMO.

mcostalba commented 7 years ago

@gbtami have you verified that all queries are correct, including streaks? It seems to me that streakStartPly is not compensated by the 2 different cases.

gbtami commented 7 years ago

@mcostalba, yes I'v printed all returned result json from current master and checked and adjusted move related rule ply values according what I suggested in #33.

Can you create a failing test case to "streakStartPly is not compensated by the 2 different cases" please?

mcostalba commented 7 years ago

Ok, I merge your patch then, if something will backfre in the future we will take care of it when it happens.