search

mcpa-stlouis / hack-the-arch

Welcome to HackTheArch! A free open source scoring server for cyber Capture the Flag competitions!
https://hackthearch.herokuapp.com
MIT License
67 stars 28 forks source link

Hints Display overflow and spam #42

Closed jetbalsa closed 6 years ago

jetbalsa commented 6 years ago

If you enter a very long hint it causes the hint display box to not expand correctly or wrap the text. also noticed that hint_table is included more then once on the page, I'm up to about 120 challenges and its not uncommon for the entire page to start hard locking in chrome or firefox as a admin.

jetbalsa commented 6 years ago

image

Also should note that adding hints is a little bit of a process, it seems like it was built for more using a hint for more then one challenge.

paullj1 commented 6 years ago

@JRWR, this is an easy fix, and I can implement it for the next release. Also, you're absolutely correct... it was built with using a hint for more than one challenge in mind, but not as the primary use case. We had several challenges that didn't have any hints, so we created one "hint" that said there weren't any hints and didn't deduct any points, then re-used it everywhere. The implementation could be better for sure, I just honestly haven't put that much thought into it. Any suggestions?

paullj1 commented 6 years ago

@JRWR Having trouble replicating. Which browser are you seeing the overflow in?

jetbalsa commented 6 years ago

Google Chrome is up to date Version 64.0.3282.167 (Official Build) (64-bit)

Win10

On Fri, Feb 16, 2018 at 6:28 AM, Paul Jordan notifications@github.com wrote:

@JRWR https://github.com/jrwr Having trouble replicating. Which browser are you seeing the overflow in?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mcpa-stlouis/hack-the-arch/issues/42#issuecomment-366211636, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxE1Ccw0QT8JYJx3UGjhrwnBaU1Jejiks5tVWZrgaJpZM4SG9nL .

paullj1 commented 6 years ago

Yeah, I got it. Sorry. That part is fixed. I might need to spend some time thinking about how to not include the hint table for each challenge. Currently, the buttons are hard coded to each challenge, so when you click "Add" on the hint, it goes to the challenge from which you opened the modal. I'm looking at turning on fragment caching for your #43, which may fix it, but isn't ideal.

jetbalsa commented 6 years ago

So simplify the input of hints where in the hints admin its just a open form fields for Hint Text and a ajax submission, load the form only when the admin switches to the hint tab for that challenge, keep it where you don't need to go off page to add a hint. quick and easy :)

Also, I noticed it doesn't show how many points are needed for a hint to the end user

On Fri, Feb 16, 2018 at 6:40 AM, Forrest Fuqua email@jrwr.io wrote:

Google Chrome is up to date Version 64.0.3282.167 (Official Build) (64-bit)

Win10

On Fri, Feb 16, 2018 at 6:28 AM, Paul Jordan notifications@github.com wrote:

@JRWR https://github.com/jrwr Having trouble replicating. Which browser are you seeing the overflow in?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mcpa-stlouis/hack-the-arch/issues/42#issuecomment-366211636, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxE1Ccw0QT8JYJx3UGjhrwnBaU1Jejiks5tVWZrgaJpZM4SG9nL .

paullj1 commented 6 years ago

Last commit actually was for #44. Sorry for the confusion.