search

mcpiroman / UnityNativeTool

Allows to unload native plugins in Unity3d editor
MIT License
184 stars 19 forks source link

Editor GUI Fixes #15

Closed rogerbarton closed 4 years ago

rogerbarton commented 4 years ago
  1. Editors (component/window) are repainted when dll's are un/loaded using the new attributes
    • Involves running the triggers on the main thread in a queue 39c4fce825d7f1c4572d183ec8666593d3840f13
  2. Editor variable changes are detected and saved properly
    • Involves creating a clone of the options and comparing changes when the GUI has changed 5bda99031c315006d66ea14aa8c7c949c7dabd6e

Note: The attributes [NativeDllLoadedTrigger] etc are not searched for in the source code of this tool itself. So by creating an .asmdef in #14 these attributes may not work, do you maybe know of an easy fix for this @mcpiroman?.

rogerbarton commented 4 years ago

Ready for review @mcpiroman.

You will probably want to review 39c4fce825d7f1c4572d183ec8666593d3840f13 separately.

(side note: #14 should already be compatible with these changes)

rogerbarton commented 4 years ago

Regarding cloning the Options, its just that we need a separate copy for detecting changes. This copy is never changed directly only update when changes are made. Its pretty safe in my opinion.

I've actually found this quite a good solution.

mcpiroman commented 4 years ago

I'm fine with that, thanks!