search

mcpiroman / UnityNativeTool

Allows to unload native plugins in Unity3d editor
MIT License
184 stars 18 forks source link

Bug fix, customLoadedTriggers with preloaded mode #18

Closed rogerbarton closed 4 years ago

rogerbarton commented 4 years ago

  1. The loaded trigger is now called after all mocked methods have been loaded for preloaded mode. This allows using a native method inside the callback, such as a initialize function.

  2. Swapped ordering so UnityPluginLoad() (from LowLevelPluginManager.OnDllLoaded(dll)) is called before the trigger. This is unrelated to the bug but makes more sense.

mcpiroman commented 4 years ago

One thing I'd like is to have that commented in the code, but otherwise yup, it makes sense to me.

mcpiroman commented 4 years ago

Oh well, I meant the comments in the actual new code, but that's also useful ;)

mcpiroman commented 4 years ago

Looks like some conflicts with comments (I can't merge that because that's your repo).

rogerbarton commented 4 years ago

Yep im just resolving them right now