mcpyproject / McPy

A open source Minecraft server written 100% in Python
GNU Affero General Public License v3.0
82 stars 16 forks source link

Fixe bugs, lot of files changed #20

Closed 0ddlyoko closed 4 years ago

0ddlyoko commented 4 years ago
ntoskrnl4 commented 4 years ago

Change ip from 0.0.0.0 to 127.0.0.1 (for tests)

This will prevent anyone outside of localhost from connecting to the server, are you sure you want to do this?

The server binds to 0.0.0.0, because that address indicates that it will receive connections from anywhere. By setting it to bind to 127.0.0.1, anyone that does not connect using 127.0.0.1 (localhost) will not be able to connect.

Read: Undo that change, it's not what you intend to do

0ddlyoko commented 4 years ago

I'm ok for a review 😄

Geolykt commented 4 years ago

It appears to be working fine here under Windows 10 1903

0ddlyoko commented 4 years ago

Appears to be working fine, however chat is not relayed to console. I do not know if it is a consequence of the changes or if it's a mistake of the main branch

Fixed

0ddlyoko commented 4 years ago

Conflict fixed

0ddlyoko commented 4 years ago

@tazz4843 could you check to this PR when you have time? I need it to be able to add more functionalities

tazz4843 commented 4 years ago

Is it okay if I merge this into master?

0ddlyoko commented 4 years ago

Yes, except if there is any other thing to fix or to improve ^^