search

mcpyproject / McPy

A open source Minecraft server written 100% in Python
GNU Affero General Public License v3.0
82 stars 16 forks source link

[IMP] Add @staticmethod to prevent Python Warning #38

Closed 0ddlyoko closed 4 years ago

Geolykt commented 4 years ago

Do you think this will work with all (if not most) Python interpreters?

0ddlyoko commented 4 years ago

Do you think this will work with all (if not most) Python interpreters?

This PR is to avoid having this kind of situation, it should work with all Python interpreters

ntoskrnl4 commented 4 years ago

Do you think this will work with all (if not most) Python interpreters?

Static methods should be supported on any half-functional Python implementation, yes

ntoskrnl4 commented 4 years ago

Unrelated, but the key() function is pretty indescriptive in terms of name

It could also be made simply an attribute of the class instead of a function

0ddlyoko commented 4 years ago

Yep but this should be done in another PR

Geolykt commented 4 years ago

So anyone against a merge of this PR?