search

mcpyproject / McPy

A open source Minecraft server written 100% in Python
GNU Affero General Public License v3.0
84 stars 15 forks source link

Add Data File parser #48

Closed 0ddlyoko closed 3 years ago

0ddlyoko commented 3 years ago

This PR will add the parser of data files

Minecraft data are taken from https://github.com/PrismarineJS/minecraft-data

For now, only blocks are imported. We'll import other data later

0ddlyoko commented 3 years ago

Done & ready for a review Only versions >= 13.0 works, we will handle versions < 13.0 later

0ddlyoko commented 3 years ago

Looks good. One thing: this currently loads multiple versions of data when we only need/are testing 1.15.2. Also, the logging in main.py has hardcoded data logs. We should change this to only log what version of data that we are loading/what we need to load.

Thanks for the review, it's strange because I'm pretty sure I have updated the code.

I think I have updated the code and I haven't pushed it, fool that I am

hydrostaticcog commented 3 years ago

Developer Left Project/PR left with conflicts

Geolykt commented 3 years ago

I have looked at the PR again (given it's relative importance) and if the merge conflicts are naively resolved it still will not start up at all due to a circulatory import. I will look at what I can do to resolve that however