mcpyproject / McPy

A open source Minecraft server written 100% in Python
GNU Affero General Public License v3.0
84 stars 15 forks source link

Am I going Insane?!? #55

Closed nonetrix closed 3 years ago

nonetrix commented 3 years ago

I wanted to change this message in main.py just as a test

[2021-01-19 21:35:11,815 - INFO - MainThread] Trying to initialize the Blackfire probe

so I edited this line: logging.info("Trying to initialize the Blackfire probe")

and changed it to logging.info("Trrying to initialize the Blackfire probe")

and it did nothing?! even check sure it was saved and opened it in nano instead of vscode and it was changed but it still does nothing

even commented it out then rebooted still nothing I can't change anything..? I want to try adding new features since the code base is small enough for me to understand

nonetrix commented 3 years ago

even opened in nano to check if it really saved and it did

hydrostaticcog commented 3 years ago

I'm not sure what your problem is. If you are wondering what the black fire probe is, I don't know what it does, other than it's not required to run the program.

nonetrix commented 3 years ago

I think I may have figured it out I'll report back

nonetrix commented 3 years ago

I have added a lot of print statements in main.py only one that seems to work is the one at the top sorry if I am doing something wrong I am not very good at this

hydrostaticcog commented 3 years ago

The actual code is in classes, so putting things in main.py would most likely not do anything. I’m not sure how much of this can be fixed via an issue here though, since it sounds like this is an issue on your end and no one else seems to be having the same issue.

nonetrix commented 3 years ago

I don't know much about classes sorry I I'll look into it ;-;

Geolykt commented 3 years ago

He is meaning the folder "classes" with classes

DevBennyturtle commented 3 years ago

this github is no longer being updated anyway, i recommend checking out mine which I will be more active in http://github.com/pamcpy/pamcpy

ntoskrnl4 commented 3 years ago

this github is no longer being updated anyway, i recommend checking out mine which I will be more active in

http://github.com/pamcpy/pamcpy

You don't need to create your own fork in order to develop the code, in fact, I'd recommend against it. The fact that no one has committed to this repo in a little bit should encourage you to commit here, not make your own fork. This is an open source project, not a forum thread where you have to make a new one if it goes inactive.

ntoskrnl4 commented 3 years ago

(I would have tagged this issue as off-topic but it seems I've lost the ability to manage issues/PRs.)

DevBennyturtle commented 3 years ago

well there are only like 1-3 people here who still have write access to this github, and i dont want to wait forever for stuff to get merged if i am the only one active in it

ntoskrnl4 commented 3 years ago

That's fair, but keep in mind we all have lives so we can't get around to everything immediately.

The PR you submitted to this repository has problems as we already described in #54. It will almost certainly be reviewed and approved once you correct that.

DevBennyturtle commented 3 years ago

I know you have lives, and the PR i submitted was a long time ago. I am already rewriting the entire project from the ground up. this is also GitHub, so we are free to do what we want as long as it doesn't violate the law but lets just agree to disagree

Geolykt commented 3 years ago

(I would have tagged this issue as off-topic but it seems I've lost the ability to manage issues/PRs.)

it appears that almost everyone has lost that right in the migration, which basically deadlocks the whole project due to no PR being acceptable

hydrostaticcog commented 3 years ago

If no one can do anything in the repo, what should we do about that?

tazz4843 commented 3 years ago

Just looked into it, turns out when 0ddly moved the repo to a team, it kinda broke permissions. I've invited @Geolykt and @ntoskrnl4 back, if anyone else needs a invite let me know.