search

mcpyproject / McPy

A open source Minecraft server written 100% in Python
GNU Affero General Public License v3.0
84 stars 15 forks source link

Re-Add MacOS support #65

Closed hydrostaticcog closed 3 years ago

hydrostaticcog commented 3 years ago

Resolves #52

Removes unsupported arguments from multiprocessing.Queue().

Changed utility for finding available threads to psutil. This was recommend by @ntoskrnl4 and could be useful later in the project.

Added psutil to requirements.txt and bumped cryptography version to 3.2 or higher, since the SSL package requires it to be 3.2 or higher.

Note: there is still one issue relating to leaked semaphore objects in multiprocessing.resource_tacker that needs to be patched.

hydrostaticcog commented 3 years ago

From my research, the error raised after shutdown about leaked semaphore objects cannot be fixed, only ignored. This error is harmless, only mildly annoying and only occurs on MacOS systems (although that kind of defeats the purpose of this PR). The only fix that I could find is simply ignoring the warning via arguments whenever you invoke main.py. We could potentially create a startup script that runs main.py with that argument to ignore the warning.