search

mcpyproject / McPy

A open source Minecraft server written 100% in Python
GNU Affero General Public License v3.0
84 stars 15 forks source link

Do not complain about the git install for arbitary reasons #69

Closed Geolykt closed 3 years ago

Geolykt commented 3 years ago

Sometimes git can also return non-0 return codes, for example if a submodule has already changes within it which would otherwise result in a overwrite. The common return code for commands that are not found is 127, however of course this needs further testing whether this also applies in other execution environment (It is likely so, but god knows if I am right).

hydrostaticcog commented 3 years ago

Before we merge, we should test on a system without git installed.

Geolykt commented 3 years ago

I should have one (actually two if I recall correctly), I'll see what I can do. In most cases this should not be an issue though

hydrostaticcog commented 3 years ago

Failed on Ubuntu Server 20.04.2 LTS

Geolykt commented 3 years ago

I cannot even test this properly on my systems as I have python 3.7.2 installed there and debian does not provide any way of upgrading it easily, ugh