mcpyproject / McPy

A open source Minecraft server written 100% in Python
GNU Affero General Public License v3.0
84 stars 15 forks source link

Minor fixes #70

Closed donno2048 closed 3 years ago

Geolykt commented 3 years ago

Some of the code you removed are remnants of old code, where as I have no real Idea what the other half does; I'll be neutral on this PR unless other things happen here

hydrostaticcog commented 3 years ago

A couple of things:

As for everything else, I'm not sure how much of these changes we need since some the files you have changed are not in use yet, and I'm not sure how future contributors will use the world generator for example. The logging catch in Multiprocessing.py is a good catch though.

donno2048 commented 3 years ago

We should leave this import, as it could be useful in the future. This file is moved in develop, so please remove this.

So, I will close this PR with a reminder to add a warning on classes/mcPy/MultiProcessing.py