search

mcr / tcpdump

the TCPdump network dissector. now moved to:
https://github.com/the-tcpdump-group/tcpdump
Other
84 stars 2 forks source link

Minor sanity checking added to addrtoname.c and tcpdump.c #25

Closed dogbert2 closed 12 years ago

dogbert2 commented 12 years ago

This code (a correction from pull request submitted on 9/3/2012) adds in sanity checking to addrtoname.c (calloc) and tcpdump.c (malloc) which in the current base repo is not performed.

infrastation commented 12 years ago

Sometimes it takes several weeks to get your commit accepted into the upstream, so you've got enough time to write a good commit message :)

dogbert2 commented 12 years ago

Ok...I sent the patch files to Michael (those were diff -u type patches), so he is aware of the fixes for malloc/bzero/memset in both tcpdump/libpcap (since both programs have some of the same issues, though tcpdump has far fewer of them).

Bill

On Tue, Sep 4, 2012 at 11:41 AM, Denis Ovsienko notifications@github.comwrote:

Sometimes it takes several weeks to get your commit accepted into the upstream, so you've got enough time to write a good commit message :)

— Reply to this email directly or view it on GitHubhttps://github.com/mcr/tcpdump/pull/25#issuecomment-8273997.