mcrapet / plowshare

Command-line tool and engine for managing sharing websites
GNU General Public License v3.0
847 stars 89 forks source link

Changed create_tempfile() permission from 600 to 644 #106

Closed salcatroppa closed 6 years ago

salcatroppa commented 6 years ago

I don't know if setting permissions to 644 for temp files causes troubles but I couldn't open the image from a webserver (symlinked /tmp to /var/www/html/tmp) and changing this made it working.

mcrapet commented 6 years ago

Hi, Your patch is not acceptable for security reason. Use --temp-directory=/var/www/html/tmp with proper permission to the directory.