mcrovero / rubber

An elastic material bottom sheet implementation for Flutter.
BSD 2-Clause "Simplified" License
562 stars 88 forks source link

Using ListView in upperLayer section cancel the drag up action #4

Closed icarus31 closed 5 years ago

icarus31 commented 5 years ago

Describe the bug I have a column with multiple rows in my upperLayer section. If I leave at it is, I get a "Bottom overflowed" error.

Column(
  children: <Widget>[
    Row(
      children: <Widget> [
      ...
      ]),
    Row(
      children: <Widget> [
      ...
      ]),
  ])

Putting the column within a ListView or similar widget remove the overflow, but now, when dragging up the section, it just scroll the ListView:

ListView(
  children: <Widget> [
    Column(
      children: <Widget>[
        Row(
          children: <Widget> [
          ...
          ]),
        Row(
          children: <Widget> [
          ...
        ]),
      ])
    ])
....

Smartphone (please complete the following information):

JohannesKaufmann commented 5 years ago

I had the same problem. If you use

new SingleChildScrollView(
        physics: const NeverScrollableScrollPhysics(),
        child: new Column(...),
)   

you can scroll the modal again but not the actual list. So I tried to toggle between NeverScrollableScrollPhysics and null whenever the user hit the top of the list but I was not able to get it to work.

For anyone trying it out, have a look at

mcrovero commented 5 years ago

I'm currently implementing the upper layer scrolling feature for my own project so it will be supported in the next release. Thanks for your interest in the project!

icarus31 commented 5 years ago

Hi @mcrovero,

I don't want to rush you, by any idea when you think you will release it?

Thanks

mcrovero commented 5 years ago

New version published! 😉 Let me know if you find any issues

icarus31 commented 5 years ago

Nice job! Working good with my gridview too! Thanks