search

mcrowe / soulmate.js

A jQuery front-end for the soulmate auto-suggestion gem
MIT License
121 stars 18 forks source link

Allow placement of solumate at a different location #2

Closed aroop closed 12 years ago

aroop commented 12 years ago

Hi,

I had a heavily customized menu bar which also has a search field. ul#soulmate was inheriting all the styles from the menu bar.

This change allows the use of placing ul#soulmate at a different place in dom which avoided css styles from propagating to solumate.

Thanks, Ajay Kumar G

mcrowe commented 12 years ago

This seems reasonable. So now if there is already a ul with id 'soulmate' in the dom, then soulmate.js will use that instead of appending a new one after the input field. This gives a little more flexibility if it's needed, but doesn't really add to the complexity of the code.

Thanks Ajay. Specs pass, and it seems to work OK. Merging on up.

aroop commented 12 years ago

I had implemented autocomplete with soulmate.js and soulmate in my (http://www.moviemyna.com). Its rocking. Thanks for the great project. Really appreciated.

mcrowe commented 12 years ago

Glad to hear it!

jaredmdobson commented 12 years ago

Thank you so much for soulmate.js!! It rocks!!!

mcrowe commented 12 years ago

@onesupercoder You're welcome. Nice to know it's getting put to good use!