search

mcrumm / phlack

Slack Integrations for PHP
MIT License
52 stars 8 forks source link

Upgrade composer requirements to the latest doctrine/collections #4

Closed rauanmayemir closed 10 years ago

rauanmayemir commented 10 years ago

I was trying to install rocketeer-slack (a php plugin notifying slack channel whenever somebody deploys an app using Rocketeer) and got stuck into broken dependencies.

My latest laravel pack is using latest doctrine/collections, so I had to fork your package and bump the composer requirements.

Since all tests on travis-ci are passing correctly, could you accept my changes? So that I could create another pull request for aforementioned plugin. :)

Btw, new tag is also needed.

(Reopening PR on develop branch)

mcrumm commented 10 years ago

Thanks, again! I'll push a new tag with this fix. Although, you should be good-to-go at this point, since I'm pretty sure the rocketeer-slack package is using my develop branch.

rauanmayemir commented 10 years ago

No, unfortunately it's not, it's bind to v0.5.

mcrumm commented 10 years ago

I've created an issue to see if the rocketeer-slack maintainer can bump the dependency version for phlack, which should resolve the problem.

rauanmayemir commented 10 years ago

Thanks, I was just going to) Besides, I had minor fixes for that too.