search

mcruncher / worshipsongs-android

Android app for Worship Songs
GNU General Public License v3.0
8 stars 8 forks source link

As a user, I can import a OpenLP database from a local path or remote URL. #275

Closed pixel2user closed 7 years ago

pixel2user commented 7 years ago

Right now I need to copy the database of my church manually into the app data folder of the worshipsongs app.

An import feature "Copy database file from local path or remote URL to local app data folder" would be enough. No need for an automatic sync mechanism.

pixel2user commented 7 years ago

@swotge - Am I right that you already implemented the remote URL feature, but decided to deleted it? https://github.com/crunchersaspire/worshipsongs-android/commit/247c9a3fadd00ff4bc83829659cd471cf2b71042

<string name="remoteUrl">https://raw.githubusercontent.com/crunchersaspire/worshipsongs-db/master/songs.sqlite</string> https://github.com/crunchersaspire/worshipsongs-android/blob/2f5b3cd4341a7ee2843fe901b736f0e21bf7def6/app/src/main/res/values/strings.xml

pixel2user commented 7 years ago

@swotge - Would be great, if an expert setting to modify this remote URL can be added to the settings menu.

ghost commented 7 years ago

@GermanGospel Can you test this issue? V3.174 is available in beta store.

pixel2user commented 7 years ago

@swotge - The app closed itself after trying to open an old favourite list, after importing a new openlp db, which does not have the songs that the favourite list has listed.

I did sent this bug description also via the Android crash report popup. Did you get the report as an e-mail? Or did it only send an e-mail to Google!?

pixel2user commented 7 years ago

@swotge -The songs from our db has been imported successfully (from internal storage)! Thank you very much! 👍

With this feature I can let our church members install this app from the PlayStore and don't have to provide a manually edited apk, which some aren't able to install...

pixel2user commented 7 years ago

@swotge - No bug, but important information for all that want to import a database via a dropbox.com link: The import via the shared link from dropbox.com failed, since the link is no direct link to a file URL but a HTML site with infos about that file. https://www.dropbox.com/s/uq51os3z0dlxv2x/songs.sqlite?dl=0

The import is successful, if suffix is changed to dl=1! 👍 https://www.dropbox.com/s/uq51os3z0dlxv2x/songs.sqlite?dl=1

pixel2user commented 7 years ago

@swotge - Feature request: It would be great if the last used URL is saved. Else the extra button "restore to default db" is a not needed, since the default db can always be retrieved via the default URL import.

ghost commented 7 years ago

@GermanGospel Thankyou very much taking time to test our app 👍

The app closed itself after trying to open an old favourite list, after importing a new openlp db, which does not have the songs that the favourite list has listed

We will work on this.

@swotge - Feature request: It would be great if the last used URL is saved. Else the extra button "restore to default db" is a not needed, since the default db can always be retrieved via the default URL import.

I will discuss with our team and come back

ghost commented 7 years ago

@swotge - The app closed itself after trying to open an old favourite list, after importing a new openlp db, which does not have the songs that the favourite list has listed.

I did sent this bug description also via the Android crash report popup. Did you get the report as an e-mail? Or did it only send an e-mail to Google!?

We have received crash report in Play store Beta section

ghost commented 7 years ago

@GermanGospel Development is done. v3.207 is available in beta store, can you test this?

pixel2user commented 7 years ago

@swotge - There is a bug in this feature! The import works, but in 'Song book' view the old songs are listed. If I selected one of the songs from the old database, the app crashes. After the crash the songs of the new database are listed.

ghost commented 7 years ago

@swotge - There is a bug in this feature! The import works, but in 'Song book' view the old songs are listed. If I selected one of the songs from the old database, the app crashes. After the crash the songs of the new database are listed.

@GermanGospel I will try to recreate this bug in our environment.

ghost commented 7 years ago

@GermanGospel Recreated this issue in our environment. I will fix this

ghost commented 7 years ago

@swotge - There is a bug in this feature! The import works, but in 'Song book' view the old songs are listed. If I selected one of the songs from the old database, the app crashes. After the crash the songs of the new database are listed.

@GermanGospel This bug is fixed in v3.232. It's available in beta store. Can you test it and give feedback?

pixel2user commented 7 years ago

@swotge - The bug is not fixed for the use case 'restore default db'! If I import a db from a remote location, all saved favourite lists are deleted. If I create a new favourite list and restore the default db, the new lists is not deleted and the app will crash, if I try to open that list. It would be great to have a warning message 'Warning: All favourite lists will be deleted if you import a new db!'

"The app closed itself after trying to open an old favourite list, after importing a new openlp db, which does not have the songs that the favourite list has listed."

madasamys commented 7 years ago

@GermanGospel The bug is recreated in our environment. We will fix this.

madasamys commented 7 years ago

@GermanGospel The bug is fixed in v3.244 which is available in beta store. Can you test it and give feedback?

madasamys commented 7 years ago

@GermanGospel , I am sorry changes not available in V3.244. Let you know once published.

pixel2user commented 7 years ago

@madasamys - The bug is fixed in V3.248! 👍