mcruncher / worshipsongs-android

Android app for Worship Songs
GNU General Public License v3.0
8 stars 8 forks source link

Display songbook below each song in complete and favorite list view. #548

Closed rafaeljohansen closed 2 years ago

rafaeljohansen commented 3 years ago

Story

As a Worship Leader, I want the songbook to be displayed below each song in complete (titles tab) and favorite list view So that I can prepare for the service along with other members in the worship team

Conditions of Acceptance

Background

As mentioned in #221, we need an option to display the key of songs in the list views (both complete list and favorite list). Because OpenLP 2.4 don't support keys and chords yet, keys can temporarily be assigned using songbooks that are given the names "Key of E", "Key of A" etc. However, OpenLP 3.0 (which currently is in the beta stage) does support keys and chords. Therefore, it would be wise to take a look at how this information is stored in OpenLP 3.0 and already add support for this. The final solution could be to add two options in the settings of your app.

Then we could temporarily use the "Display songbook" option until OpenLP 3.0 (with key support) has an official release. (The "Display songbook" option could anyway be quite useful for several reasons)

A similar feature we use in "Worship leader" is there called "Show key, time signature and tempo in song list".

Ref #221:

@sskjames: "The app does support defining the key for a song via defining a property in "Theme, Copyrights & Comments" section of a song in OpenLP. But the key is displayed only in the presentation view of the app, I think. It should be quite easy to display it below the song. Can you please create a new issue for this?"

pitchumani1989 commented 3 years ago
pitchumani1989 commented 3 years ago

Shown songbook below songs in titles list view

Screenshot_1622189424

sskjames commented 3 years ago

Looks good @pitchumani1989. Hi @rafaeljohansen, any feedback? Of course, these are Tamil songs but the point is @pitchumani1989 has added support to display the Song Books below each song. If a song belong to multiple Song Books, they will be separated by a comma. There is also a setting to turn on/off this behaviour.

pitchumani1989 commented 3 years ago

Added a setting to turn on/off this behaviour

Screenshot_1622190368_1

sskjames commented 3 years ago

Tested and observed the following:

Found the following issues:

sskjames commented 3 years ago
sskjames commented 3 years ago

Song book names are not displayed for songs in existing favourites. Need to fix this as well.

sskjames commented 3 years ago

Merged the changes. Triggered a build. Once the build is successful, will make this build available for open beta testing.

sskjames commented 2 years ago

Tested the beta build 3.5.0.450 in a phone running Android 11 and found that everything works as expected. Will proceed to release v3.5.0.