mcruncher / worshipsongs-ios

GNU General Public License v3.0
3 stars 5 forks source link

Wrong song lyrics is displayed when tapping the search result in ipad. #281

Closed sskjames closed 2 years ago

sskjames commented 2 years ago

What was the activity?

What was observed?

The lyrics of another song was displayed

sskjames commented 2 years ago

Got a TestFlight build and tested this in iPad. Now the correct song is displayed when tapping a search result. Also observed that the search result persists, which is good, when switching tabs. Tested also in iPhone.

sskjames commented 2 years ago

Observed that this change has caused another problem. Let us say the user searches for the text "Anbu" in the Titles tab and a filtered list of songs are displayed. Now the user goes to the "Author" tab. The search bar will be displayed in the "Author" tab with the text "Anbu". If the user cancels the search while in "Author" tab and comes back to "Titles" tab, the search result still persists, but the search bar is empty. Now this would leave the user wondering how to clear the search result. The only workaround now is to tap inside the search bar again.

sskjames commented 2 years ago

Here is the workflow which explains this problem:

  1. User is in Songs tab
  1. User enters some search text
  1. User switches to Artists tab
  1. User cancels the search
  1. User switches back to Songs tab (Please notice that the previous search results are displayed even though the search text is empty)
  1. User taps the search bar (Please notice that the search result is cleared now and the default list of songs is displayed)
sskjames commented 2 years ago

If this is acceptable, then we can leave it as it is.

sskjames commented 2 years ago

Had a chat with Vicky about this and we felt that it's okay to go with this behaviour.