Fix possible mistakes in crew ordering

[mcshane-fire]

Following on from merge request bc1e214d65efc2652090508dfd29f98f77f1bdd9 and b7d260ac2336f7a96dfa8eb2d7aa78081ae63e89, I implemented support for checking that crews from a single club appear in numerical order. I've since fixed a bunch of the CRA results, there are more errors flagged by CRA results but they all match with the charts on https://cantabsrowing.org.uk/, so are likely not mistakes.

The remaining errors flagged from Eights, Lents, Mays & Torpids should be checked, since they may point to more errors in crew listings. See the text file attached.

wrong.txt

[mcshane-fire]

@johnwalley I've found more potential crew errors for us to check out here.

[johnwalley]

The college bumps errors feel like they're going to mostly be real errors in the crew listings but I suppose we should check.

The 1984 womens Torpids looks like New College II should be New College for example (looking at the multi year charts).

Edit:

Or maybe not. That's just me eyeballing the charts. The underlying results file has it as New College II (https://eodg.atm.ox.ac.uk/user/dudhia/rowing/bumps/newc/newc_w2t.txt)

[mcshane-fire]

CRA results are verified Eights results all match Anu's charts, apart from 2019 Men (change pending) Lents 2007 Men & Women: have fixes which match https://en.wikipedia.org/wiki/Lent_Bumps_2007 2011 Men: have fix which matches https://en.wikipedia.org/wiki/Lent_Bumps_2011 2012 Men: have fix which matches https://en.wikipedia.org/wiki/Lent_Bumps_2012 2013 Women: have fix which matches http://www.cucbc.org/bumps/results/9/2 (wikipedia is wrong) 2014 Men: have fix which matches http://www.cucbc.org/bumps/results/11/1

Changes above in 6b5f063f4ca16fb7971eebf0b8ec36363f189951

I've not yet checked Mays or Torpids results.

I have no source material to check these:

results/lents1957_men.txt Club LMBC crews out of order (found 5, expecting 4) Club LMBC crews out of order (found 4, expecting 6) Club LMBC crews out of order (found 6, expecting 5)

results/lents1966_men.txt Club Downing crews out of order (found 3, expecting 2) Club Downing crews out of order (found 2, expecting 4) Club Downing crews out of order (found 4, expecting 3)

results/lents1988_women.txt Club Girton crews out of order (found 2, expecting 3)

results/lents1989_men.txt Club LMBC crews out of order (found 5, expecting 4) Club LMBC crews out of order (found 4, expecting 6) Club LMBC crews out of order (found 6, expecting 5)

results/lents1990_men.txt Club LMBC crews out of order (found 5, expecting 4) Club LMBC crews out of order (found 4, expecting 6)

results/lents1991_men.txt Club LMBC crews out of order (found 5, expecting 4) Club LMBC crews out of order (found 4, expecting 6) Club LMBC crews out of order (found 6, expecting 5)

[johnwalley]

I have a CD, which I've mislaid, with Lents results on it. If I can find it, and find a way to read it, I can double check the Lents crew ordering.

[mcshane-fire]

Looking at charts that span multiple years, these errors make a little more sense.

1957: LMBC 5 bumped LMBC 4 on the last day in 1956, so the start ordering for 1957 is from the finish order. In 1957 the bumps don't bump each other, in 1958 the numbers are swapped for the start order. So either 1957 is a mistake or they were allowed to have boats out of order for whatever reason.

1966: Downing is similar, their 3rd boat bumps their 2nd boat the previous year, so the start order is the same as the finish order from 1965. After 1966 the order was swapped back correctly for 1967.

1988: There are two Girton 2nd boats, starting next to each other. Looking at the 1987/1988/1989 results in combination, I'm certain that the second of these is actually Homerton 2. I've made that correction with 7e0eda5db4c7930912561a570baefcefc0bdd00d.

1989-1991: In 1988 LMBC 5 bumps LMBC 4, so the 1989 start order reflects the 1988 finish order. This is maintained for the next couple of years, in 1992 the results have the crew orders corrected.

My guess is that the other issues are mistakes in the crew order, but we'd need other sources to check. I've asked George Gilbert if he can help, since his book & CD are out of print.

[johnwalley]

I've just checked 1957 and 1966 and both are mistakes by me. I think it's safe to assume the others are mine too.

I have a copy of The Bumps; which is where I must have got these results and I've just checked against. I can provide a copy of the CD if it would be of use. Although, if we can get the raw results that would be super useful. There will almost certainly be other mistakes where I've manually entered results based on charts.

[mcshane-fire]

I've committed those changes to Lents Men's results in bee182d0ba51527e2ef0ed077ebcb12bbc1ddb56.

[mcshane-fire]

Lent's women results had one issue in 2012, Clare Hall were listed as their 2nd boat not their first boat, I've fixed this to match http://www.cucbc.org/bumps/results/7/2 in aa85d1fb79a52b4b233dda73da5d191170247e36.

[mcshane-fire]

Mays Womens:

2004: New Hall 4 and 5 swapped in the bottom division - this matches a bumps chart I have from this year. Wikipedia only has top two divisions. I'll leave this one was it is. 2005: Peterhouse 3: the bumps chart I have from this year has their crew at the top of the last division as Peterhouse 2.,

Mays Men:

2010: LMBC 5 & 6: fixed to match https://cucbc.org/charts?year=2010&event=M&day=Fi&sex=M 2014: Clare 5: Clare 5 changed to Cl4 to match http://www.cucbc.org/bumps/results/12/3 2014: Pembroke 6: Left as is, looks like Pb5 failed to get on, matches http://www.cucbc.org/bumps/results/12/3 2015: Clare 4: Renamed Cl5 to Cl4 to match http://www.cucbc.org/bumps/results/14/1 2016: Caius 4: Renamed Ca5 to Ca4 to match https://www.cucbc.org/bumps/results/16/3 2017: Caius 4: Renamed Ca5 to Ca4 to match https://www.cucbc.org/bumps/results/18/3 2018: Fitz 3: Renamed F5 to F3 to match https://www.cucbc.org/bumps/results/20/3

Changes above committed as cf2322f6ce10d0c1470534a2e85d7fd2f91d3f24.

[mcshane-fire]

Torpids Women:

1984: New College 2: I agree that this should be New College, not their second boat, given the results over the year before and years after. 1994 & 1995: St John's 3: Nothing to help here from other years or sites other than Anu's, I'll leave as this is.

Torpids Men:

1984: Queens 3/4: These boats swapped over in 1982, then the lower boat drops out, in 1983 it's listed as Q3, then 1984 as Q4, then 1985 onwards as Q3. I think Anu's results are wrong so I'll change this to Q3. 1999: SEH 2: First boat miss one year, but are then put back in a the following year, so I'll leave this as SEH2. 2001: Linacre 2: Same as above, first boat misses a year, then put back. Leaving this as it is.

Committed these changes as 6a04d056c7c37b6fd7866a2e811ceb9ed6d5a3ca.

[mcshane-fire]

Updated list of incorrect crew number warnings: wrong.txt

I've created #14 to help avoid printing this error when it's intentional, I think that's a better strategy than turning the error off. I'll leave this issue open as I'll review each of the errors again before mark it as intentional.

[mcshane-fire]

I've reviewed the crew order warnings from Eights results, they match Anu's charts but those may have errors.

1958 Men - Oriel 5 (missing 4th boat): not enough data from previous/next year to say this is an error 1984 Women - New College 3 (missing 2nd boat): seem more like to be their second boat, based on the following 2 years, but it's not clear 1999 Women - Keble 4 (missing 3rd boat): no information from previous or next year to know if this is an error 2004 Men - Christ Church 3 & 4: given the results from previous & next year I'm certain that this is an error, so I've fixed this in a6f319eec581770f0e9d8dc42dc71229fdd9bdce. 2004 Women - Queen's 3 & 4 (4th above 3rd boat): No information from previous or next year to say this is an error