AEP: 26_make_ptable.R - Githubissues

mcsiple / mmrefpoints

A package for simulating marine mammal abundance and calculating reference points.

Other

3 stars 5 forks source link

AEP: 26_make_ptable.R #28

Closed mcsiple closed 3 years ago

mcsiple commented 3 years ago

[x] You need to add a return statement
[x] It is a pity mnpl is not computed from the parameters in lh.parms
[x] Check there are enough years
[x] Do you need lh.params given the list from projections should contain all the needed parameters
[x] I can’t get this to work!! What am I passing wrong..
[x] check AEP edits in doc (attached to email)

mcsiple commented 3 years ago

MNPL is specified in the function because the user specifies MNPL in Shiny. I have added an option to calculate MNPL if and only if MNPL is not provided by the user ( commit ec78b75c ). More fixed later!

mcsiple commented 3 years ago

Rest of comments fixed with commit c5111562 and d4f05c36.